Feat/auth token middleware #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austin2Shih
requested changes
Apr 1, 2024
| * @param token - The token to be verified. | ||
| * @returns The response indicating the success or failure of token verification. | ||
| */ | ||
| export function verifyToken(token: Token): VerifyTokenResponse { |
There was a problem hiding this comment.
Does this check for token expiration? We probably want to check for that here or at least somewhere in the process.
There was a problem hiding this comment.
it does, jwt.verify should return the decoded token only if it's valid and not expired, otherwise it throws an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.